-
Notifications
You must be signed in to change notification settings - Fork 4
feat: rMPP support #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@NoaHimesaka1873 there are merge conflicts, could you resolve them? To further help things, could you add a test that just compiles a very simple hello world c program as part of creating the package, and then ensure that it creates an executable with the correct architecture after doing a build? This would be the test I would be doing manually otherwise. I'm guessing this is still waiting on toltec-dev/toolchain#41 though? |
|
Yeah I could make one, though it would need v4 to be merged first. |
|
You would be able to do the test locally by downloading the v4 images from the v4 PR pipeline before they are removed, but yes, it would require it being merged before this can be fully tested. |
|
While testing toltec-dev/toolchain#41 I was using the following recipe for testing: #!/usr/bin/env bash
# Copyright (c) 2020 The Toltec Contributors
# SPDX-License-Identifier: MIT
archs=(arm aarch64)
pkgnames=(hello)
pkgdesc="Hello world"
url=https://toltec-dev.org
pkgver=0.0.0-1
timestamp=2025-10-27T18:32:23Z
section=utils
maintainer="Nathaniel van Diepen <[email protected]>"
license=MIT
image=toolchain:v4.0
source=(hello.c)
sha256sums=(SKIP)
flags=(nostrip)
build() {
source /opt/x-tools/switch-$arch.sh
${CROSS_COMPILE}gcc hello.c -o hello
${CROSS_COMPILE}strip hello
}
package() {
install -D -m 755 "$srcdir"/hello "$pkgdir"/opt/bin/hello
}
With the following source file: #include <stdio.h>
int main(){
printf("Hello, World!");
return 0;
}This would need to be update to use the correct archs etc. Now that I'm playing with this and looked at #57 I'm realizing that there is still an issue that will make implementing this in the actual repo difficult. There is no way to specify a different image per arch, and since v4.0 is not compatible with the current supported 3.x images that rmallos3, rm1os3, and rm2os3 target, this means that you can't target them at the same time as rmppos3 for packages that need to compile anything. The options I see for merging this are:
|
|
Please also add rmppm, even though it'll be the same as rmpp, but it allow for packages to target just one specifically. Although this means we'll need a rmall equivalent for just rmpp and rmppm. It may make sense to have a rmarm and rmaarch? |
|
Wrote test case! |
|
You'll want to run |
|
builder.py line 333 still remains over 80 characters, gotta fix manually... |
|
I chose more variables over super long lines. |
|
Urgh, should be now actually fixed |
|
I'll merge this tomorrow, but I'm not going to tag 0.4 yet, I've got to sort out the concern I raised at the bottom of #58 (comment) I'd really like to allow custom images per arch. I may also implement #43 |
|
Upon reviewing the code, my concern about different image per arch not being possible is not true, you can specify |
No description provided.